Skip to content

Fix/ Position of the Banner#1471

Merged
priyankarpal merged 2 commits intoreactplay:mainfrom
Akshaygore1:fix/#1449
Feb 24, 2024
Merged

Fix/ Position of the Banner#1471
priyankarpal merged 2 commits intoreactplay:mainfrom
Akshaygore1:fix/#1449

Conversation

@Akshaygore1
Copy link
Copy Markdown
Contributor

@Akshaygore1 Akshaygore1 commented Feb 24, 2024

Changed the Alignment of the Banner Content
Screenshot 2024-02-24 at 21 00 42

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 24, 2024 •
edited
Loading

✅ Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit f713043
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65da0ca50ec50800082aa826
😎 Deploy Preview https://deploy-preview-1471--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Feb 24, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Akshaygore1 Akshaygore1 mentioned this pull request Feb 24, 2024
Closed
4 tasks
priyankarpal
priyankarpal approved these changes Feb 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit 98a37da into reactplay:main Feb 24, 2024
@priyankarpal
Copy link
Copy Markdown
Member

priyankarpal commented Feb 24, 2024

hello @Akshaygore1 thanks for the pull request. I appreciate your work. a suggestion that when you open a pull request please add the issue number to the PR description also we follow conventional commits so use the format. also, check the conventional commits docs https://www.conventionalcommits.org/en/v1.0.0/

example:

- Fix/Position of the Banner #1471
+ fix: banner position #1471

@Akshaygore1
Copy link
Copy Markdown
Contributor Author

Akshaygore1 commented Feb 24, 2024

hello @Akshaygore1 thanks for the pull request. I appreciate your work. a suggestion that when you open a pull request please add the issue number to the PR description also we follow conventional commits so use the format. also, check the conventional commits docs https://www.conventionalcommits.org/en/v1.0.0/

example:

- Fix/Position of the Banner #1471
+ fix: banner position #1471

Thanks For Feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

Assignees

@Akshaygore1 Akshaygore1

Labels

🛠 goal: fix Bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Akshaygore1 @priyankarpal